Cross-compile to sbt 2 - #64
Merged
Merged
Conversation
anatoliykmetyuk
force-pushed
the
sbt2-port
branch
from
January 7, 2026 07:08
bfffa89 to
665b491
Compare
mkurz
reviewed
Jan 12, 2026
| scala: 2.12.21, 3.7.2 | ||
| cmd: | | ||
| sbt ++$MATRIX_SCALA test ^scripted | ||
| sbt ++$MATRIX_SCALA test +scripted |
Member
There was a problem hiding this comment.
@anatoliykmetyuk @BillyAutrey shouldn't this just be
Suggested change
| sbt ++$MATRIX_SCALA test +scripted | |
| sbt ++$MATRIX_SCALA test scripted |
?
The scala versions in the build matrix already take care that the tests run for each scala version.
Like
- https://github.com/sbt/sbt-coffeescript/actions/runs/20773547651/job/59654317522?pr=64
- https://github.com/sbt/sbt-coffeescript/actions/runs/20773547651/job/59654317524?pr=64
run both for 3.7.2 and 2.12.x each? Or am I wrong?
There was a problem hiding this comment.
I do typically remove the + when running with the matrix, you're right. Locally I test with +scripted.
mkurz
reviewed
Jan 12, 2026
|
|
||
| ThisBuild / (pluginCrossBuild / sbtVersion) := { | ||
| scalaBinaryVersion.value match { | ||
| case "2.12" => "1.11.7" |
Member
There was a problem hiding this comment.
I think we can already switch to 1.12.0 everywhere (also other places in the repo). @BillyAutrey @anatoliykmetyuk wdyt?
mkurz
reviewed
Jan 12, 2026
| @@ -1,3 +1,7 @@ | |||
| lazy val scala212 = "2.12.20" | |||
| lazy val scala3 = "3.7.2" | |||
mkurz
reviewed
Jan 12, 2026
| @@ -1,3 +1,7 @@ | |||
| lazy val scala212 = "2.12.20" | |||
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.